2

Closed

Add tracing for filter overrides

description

IOverrideFilter doesn't have any behavior itself; it is used as a marker for the filter pipeline processing, so the tracer for the filter itself doesn't output anything (since there are no methods on this filter interface).

Adding tracing to FilterGrouping would allow showing the effect of filter overrides in the trace output.
Closed Dec 30, 2013 at 8:27 PM by eilonlipton
We discussed in triage and decided that this information is not sufficiently important for tracing. We figured that if someone is using filter overrides, they probably already know what's going on, or aren't interested. Ultimately the tracing shows the net effect of the overrides, which is the most important information.

comments

eilonlipton wrote Dec 30, 2013 at 5:23 PM

Hongye, can you take a look at this and see how bad the situation is? When filter overrides are used, what gets traced? Nothing at all? Or do the resultant set of filters get properly traced? If it's just the case that there is no explicit mention of the filter overrides doing some magic in the background, then we're no too worried about this.

hongyes wrote Dec 30, 2013 at 6:30 PM

When the filter overrides are used, the overridden filters are not traced but the effective filters are still traced. As the issue described, override filter itself is not traced.

Since the override filter is not traced, it might be confusing when the developer tries to figure out why global filters are not executed from tracing.