ASPNETWebStack Issue Tracker Rss Feed

Edited Issue: Update the Web API OWIN adapter to use Microsoft.Owin once it behaves well [1054]

youssefm — Tue, 21 May 2013 23:25:47 GMT

Biggest adoption blockers identified so far are:

1. Potential null refs when computing URIs
2. Doesn't throw when required keys are missing from the environment, or when the environment has the wrong type for a particular key

Edited Unassigned: [WebApiOnOwin]Uploading a 2GB file with custom input buffer selector set to true fails [1036]

kamehrot — Tue, 21 May 2013 23:25:35 GMT

Repro sample : FileUploadSample (file://KK-MC2/FileUploadSample)

I have a simple custom buffer selector where UseBufferedInputStream returns true.

When I try to upload a 2GB fails, I am seeing a failure with below stack trace.

{"The stream does not support concurrent IO read or write operations."}

at System.Net.ConnectStream.InternalWrite(Boolean async, Byte[] buffer, Int32 offset, Int32 size, AsyncCallback callback, Object state)
at System.Net.ConnectStream.BeginWrite(Byte[] buffer, Int32 offset, Int32 size, AsyncCallback callback, Object state)
at System.Net.Http.StreamToStreamCopy.TryStartWriteSync(Int32 bytesRead)
at System.Net.Http.StreamToStreamCopy.BufferReadCallback(IAsyncResult ar)
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
at FileUploadSample.Program.<RunClient>d__0.MoveNext() in e:\TestProjects\FileUploadSample\Program.cs:line 72
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.AsyncMethodBuilderCore.<ThrowAsync>b__1(Object state)
at System.Threading.QueueUserWorkItemCallback.WaitCallback_Context(Object state)
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.QueueUserWorkItemCallback.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem()
at System.Threading.ThreadPoolWorkQueue.Dispatch()
at System.Threading._ThreadPoolWaitCallback.PerformWaitCallback()

Edited Unassigned: [WebApiOnOwin]Uploading a 2GB file with custom input buffer selector set to true fails [1036]

kamehrot — Tue, 21 May 2013 23:16:09 GMT

Edited Issue: Document that IValueProvider.GetValue() returns null if the exact key is not found [1056]

yishaigalatzer — Tue, 21 May 2013 23:01:29 GMT

Document that IValueProvider.GetValue() returns null if the exact key is not found.

This applies to both MVC and WebAPI versions.

Edited Unassigned: Provide a way to specify actual return type for actions returning IHttpActionResult. [1045]

kamehrot — Tue, 21 May 2013 22:17:44 GMT

OData and HelpPage areas are effected by this:

__OData__
__Error__:
{"Message":"An error has occurred.","ExceptionMessage":"Cannot create an EDM model as the action 'Get' on controller 'Customers' has a return type 'System.Web.Http.IHttpActionResult' that does not implement IEnumerable<T>.","ExceptionType":"System.InvalidOperationException","StackTrace":" at System.Web.Http.ApiController.<InvokeActionWithExceptionFilters>d__a.MoveNext() in c:\\WebstackRuntime\\Runtime\\src\\System.Web.Http\\ApiController.cs:line 355\r\n--- End of stack trace from previous location where exception was thrown ---\r\n at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()\r\n at System.Web.Http.Tracing.Tracers.HttpControllerTracer.<ExecuteAsyncCore>d__5.MoveNext() in c:\\WebstackRuntime\\Runtime\\src\\System.Web.Http\\Tracing\\Tracers\\HttpControllerTracer.cs:line 88\r\n--- End of stack trace from previous location where exception was thrown ---\r\n at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()\r\n at System.Web.Http.Tracing.ITraceWriterExtensions.<TraceBeginEndAsyncCore>d__21`1.MoveNext() in c:\\WebstackRuntime\\Runtime\\src\\System.Web.Http\\Tracing\\ITraceWriterExtensions.cs:line 535\r\n--- End of stack trace from previous location where exception was thrown ---\r\n at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()\r\n at System.Web.Http.Dispatcher.HttpControllerDispatcher.<SendAsync>d__0.MoveNext() in c:\\WebstackRuntime\\Runtime\\src\\System.Web.Http\\Dispatcher\\HttpControllerDispatcher.cs:line 69"}

__Code__:
```
public class Customer
{
public int Id { get; set; }

public string Name { get; set; }

public int Age { get; set; }
}

public class CustomersController : ApiController
{
public IHttpActionResult Get(ODataQueryOptions opts)
{
List<Customer> customers = new List<Customer>();
customers.Add(new Customer()
{
Id = 1,
Age = 31,
Name = "John"
});
customers.Add(new Customer()
{
Id = 2,
Age = 42,
Name = "Mike"
});
customers.Add(new Customer()
{
Id = 6,
Age = 14,
Name = "Abe"
});

IQueryable results = opts.ApplyTo(customers.AsQueryable());
return Content<IQueryable<Customer>>(HttpStatusCode.OK, results as IQueryable<Customer>);
}
}
```

__HelpPage__
HelpPage generates samples based on the return type of the actions. If IHttpActionResult is the declarated return type of the action, then HelPage will not be able to generate samples. This behavior is not something new and users today already would see this experience if someone returns the type HttpResponseMessage.

There is a workaround for this in HelpPage, where users can explicitly set samples for specific actions which return HttpResponseMessage and this workaround could be used for actions returning IHttpActionResult too.

But this workaround would be too cumbersome on users as going forward users might tend to return IHttpActionResult from all their actions due to their easy testability.

David & Yao already have some ideas regarding this and this issue is to keep track of it.

Edited Issue: ASP.NET Web API does not call GetRouteData for custom HttpRoutes [453]

kamehrot — Tue, 21 May 2013 21:16:50 GMT

Here is the issue explained and a repro http://stackoverflow.com/questions/12544150/asp-net-web-api-rtm-and-subdomain-routes

Edited Issue: PushstreamContent in Win8 App is not working [324]

kamehrot — Tue, 21 May 2013 21:14:39 GMT

I am hitting an issue with using PushStreamContent in the Windows store app. I don’t see the same issue in the traditional console app though.

It’s a simple scenario where I am ‘POST’ing some small data to a service using PushStreamContent as below.

HttpClient client = new HttpClient();
var request = new HttpRequestMessage(HttpMethod.Post, "http://.../SimpleMvcWebAPIApplication/api/values");
request.Content = new PushStreamContent((stream, httpContent, transportContext) =>
{
using (var streamWriter = new StreamWriter(stream))
{
string data = "\"hello world\"";
streamWriter.Write(data);
streamWriter.Flush();
}
}, "application/json");

var response = await client.SendAsync(request);
response.EnsureSuccessStatusCode();

It fails as below.

System.ObjectDisposedException was unhandled by user code
HResult=-2146232798
Message=Cannot access a closed Stream.
Source=mscorlib
ObjectName=""
StackTrace:
at System.IO.__Error.StreamIsClosed()
at System.IO.MemoryStream.Seek(Int64 offset, SeekOrigin loc)
at System.Net.Http.HttpContent.<>c__DisplayClassf.<LoadIntoBufferAsync>b__d(Task copyTask)
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
at App5.App.<SimpleWebAPIService_Write_Temp1>d__f.MoveNext() in c:\personal\maying\WinRT\client\WinRTClient\App.xaml.cs:line 368
InnerException:

Commented Issue: Add support for conditional attributes in the Html helpers [476]

Meryovi — Tue, 21 May 2013 17:46:31 GMT

Today, if a user puts the following in a CSHTML page:

@Html.TextBox("myname", "mytext", new { disabled = isDisabled })

this will render a "disabled" attribute whose value will be set to True or False. This is inconsistent with HTML's handling of boolean attributes, and it's also inconsistent with the work we did in Razor v2 to support conditional attributes in Razor markup.

This suggestion is to add conditional attribute logic to the Html helpers so the above would conditionally display the disabled attribute (provided that isDisabled is a boolean).
Comments: I think this should also handle null values as asked in [this StackOverflow question](http://stackoverflow.com/questions/16673903/inconsistent-null-attribute-handling-in-asp-net-mvc-4).

Created Unassigned: Make ODataQueryOptions behave more like a property [1061]

jacalvar — Tue, 21 May 2013 17:38:51 GMT

As of right now, every time the user calls EntitySetController.QueryOptions we create a new instance of ODataQueryOptions<T>.

This causes some problems when the user calls it several times and makes changes on one of the instances as the customer expects the same instance to be returned every time he calls EntitySetController.QueryOptions.

Created Unassigned: [HelpPage]Do not display parameter info when action parameter is HttpRequestMessage [1060]

kichalla — Tue, 21 May 2013 17:00:21 GMT

For the following action, we are currently displaying parameter info(attached an snapshot image) in help page:
```
public IEnumerable<string> Get(HttpRequestMessage request)
{
return new string[] { "value1", "value2" };
}
```

We should avoid displaying this information as from end user's perspective, it doesn't make sense.

We already do not show parameter info for parameter CancellationToken. We could add one more check for HttpRequestMessage too.

In "\Areas\HelpPage\Views\Help\DisplayTemplates\Parameters.cshtml":
```
// Don't show CancellationToken because it's a special parameter
if (!typeof(CancellationToken).IsAssignableFrom(parameter.ParameterDescriptor.ParameterType))
{
```

Edited Issue: JQuery Validation plugin - include additional-methods file [1057]

eilonlipton — Tue, 21 May 2013 16:43:11 GMT

The JQuery Validation plugin is normally bundled with a file named additional-methods.js that adds some more validation methods to the basic ones that are in the plugin.

Two of which, 'accept' (for validating mime-types on input[type=file]) and 'extension' for validating file extensions (again, on input[type=file]), have support within MVC in the form of validation attributes (FileExtensionsAttribute and AcceptAttribute)

Currently the templates provided does not include that additional file, hence out-of-the-box these validation attributes only apply on server-side.

A fix would be to either add the nuget-package for the additional methods into the template, or to update the JQuery.validation nuget package to always include the additional methods file.
The default Bundle for jquaeyval should be updated as well.

Edited Issue: Validation - consider using FileExtensionsAttribute from System.ComponentModel.DataAnnotations [1059]

eilonlipton — Tue, 21 May 2013 16:42:49 GMT

The said attribute is new in .net 4.5

We should consider obsoleting out own FileExtensions attribute if the new attribute can be made to work with instances of HttpPostedFileBase (it is currently only for strings)

Otherwise we could consider identifying cases of the .net attribute being set on HttpPostedFileBase properties, and somehow notify the developer about using the correct attribute instead.

Commented Feature: $format is not supported [582]

vgolynets — Tue, 21 May 2013 14:43:40 GMT

ODATA services should support $format ($format=json and $format=atom) query string parameters.
As described here http://www.odata.org/documentation/uri-conventions#FormatSystemQueryOption .
Comments: Actually solution proposed by raghuramn does not work. I tried these variants: config.Formatters.XmlFormatter.AddQueryStringMapping("$format", "xml", "application/atom+xml"); config.Formatters.XmlFormatter.MediaTypeMappings.Add(new QueryStringMapping("$format", "xml", "application/atom+xml")); And both of them do not work. The only way that works for me I found in this post http://stackoverflow.com/questions/16455501/why-doesnt-my-odata-response-have-navigation-properties Post above has another reference to https://gist.github.com/raghuramn/5556691 by RaghuRam Nadiminti. RaghuRam Nadiminti advised to add custom handler into config.MessageHandlers that could override Accept header. So question, is advise about formatters actual?

Created Issue: Validation - consider using FileExtensionsAttribute from System.ComponentModel.DataAnnotations [1059]

kenegozi — Mon, 20 May 2013 22:28:52 GMT

Created Task: JQuery validation plugin - version upgrade [1058]

kenegozi — Mon, 20 May 2013 22:17:20 GMT

MVC currently bundles version 1.10 from September 2012, the latest is 1.11.1 from March 2013.

Created Issue: JQuery Validation plugin - include additional-methods file [1057]

kenegozi — Mon, 20 May 2013 22:14:09 GMT

Commented Issue: FileExtensionsAttributeAdapter no longer works with jQuery validate [882]

kenegozi — Mon, 20 May 2013 21:51:52 GMT

The "Accept" rule in the latest version of jQuery Validate now expects a mime type to be specified, not a file extension.

A new "Extensions" rule has subsequently been added for this purpose.

Note that as of v1.90 both of the above rules are now available separately inside the "Additional Methods" download.
Comments: The solution: 1. FileExtensions attribute will evaluate to the 'extension' method of JQuery Validation, and Accept attribute will evaluate to the 'accept' method 2. If the 'extension' method is not present (using MVC5 with an older version of jquery validation) then the FileExtensions attribute would use the 'accept' method, and Accept attribute will be ignored on the client side altogether. Fixed in https://aspnetwebstack.codeplex.com/SourceControl/changeset/803b6de9af1b4e77f805071bd9e521687903681b

Edited Issue: FileExtensionsAttributeAdapter no longer works with jQuery validate [882]

kenegozi — Mon, 20 May 2013 21:51:52 GMT

Commented Issue: Empty SingleResult cannot be formatted by the ODataFormatter [1040]

kenegozi — Mon, 20 May 2013 21:49:36 GMT

public override SingleResult<Customer> GetCustomer(int key)
{
return SingleResult.Create(Enumerable.Empty<Customer>());
}
Comments: Returning a 404 response when SingleResult has an empty feed Fixed in https://aspnetwebstack.codeplex.com/SourceControl/changeset/3fd6562cad19160992429ce12f378cdfb03c16e2

Edited Issue: Empty SingleResult cannot be formatted by the ODataFormatter [1040]

kenegozi — Mon, 20 May 2013 21:49:36 GMT

public override SingleResult<Customer> GetCustomer(int key)
{
return SingleResult.Create(Enumerable.Empty<Customer>());
}