Amends to ValidationMessage

Topics: ASP.NET MVC
Mar 1, 2014 at 1:05 PM
I'm considering submitting a small pull request to add an additional feature to the MVC ValidationSummary. Currently the heading of this summary is hardcoded to be a <span> tag.

In discussions with accessibility experts it's been reported that this isn't ideal - it should really be a heading tag (e.g. <h2>) such that screen readers will pick up this important information.

Currently ValidationSummary has a number of overloads. If I were to add a new parameter for the tag as additional overloaded methods, this would mean there would be another 4 or 5, which seems quite a lot. An alternative would be to add an optional parameter to the current methods.

Both of those would be backward compatible (if not passed, the existing default of <span> would be used.

So... questions.

1) Is this suitable for consideration as a pull request?
2) If so, which approach (more overloads or optional parameters) would you recommend/prefer?

Thanks

Andy
Mar 17, 2014 at 11:52 PM
Anyone from the team able to address these questions?

Thanks

Andy
Developer
Apr 12, 2014 at 2:20 AM
Filed bug #1836 to cover this issue. Current PR going through our usual process.